Allow deletion of a namespace where a cassdc exists#813
Draft
adejanovski wants to merge 2 commits intomasterfrom
Draft
Allow deletion of a namespace where a cassdc exists#813adejanovski wants to merge 2 commits intomasterfrom
adejanovski wants to merge 2 commits intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does:
This pull request introduces changes to improve the handling of CassandraDatacenter deletion scenarios and updates the workflow integration tests. The most important changes include adding a check to skip certain operations during deletion, refining validation logic, and enabling a new test case in the workflow configuration.
Improvements to CassandraDatacenter deletion handling:
internal/controllers/cassandra/cassandradatacenter_controller.go: Updated the validation logic in theReconcilefunction to ensure that validation errors are ignored if the CassandraDatacenter resource is in the process of being deleted.pkg/reconciliation/context.go: Added a check in theCreateReconciliationContextfunction to skip management client creation if the CassandraDatacenter resource is being deleted, logging a message instead.Workflow integration tests:
.github/workflows/workflow-integration-tests.yaml: Enabled thenamespace_deletiontest case in the workflow integration tests configuration.Which issue(s) this PR fixes:
Fixes #812
Checklist